Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maven-compiler-plugin to revision the version and add mvnw script to unify the maven version #836

Merged
merged 13 commits into from
Apr 19, 2019

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Apr 19, 2019

Ⅰ. Describe what this PR did

  1. ues flatten-maven-plugin to revision the version

  2. add mvnw script to unify the maven version

Ⅱ. Does this pull request fix one issue?

No

Ⅲ. Why don't you add test cases (unit test/integration test)?

not needed

Ⅳ. Describe how to verify it

CI pass

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete server/sessionStore/root.data and ignore

@lovepoem
Copy link
Member Author

delete server/sessionStore/root.data and ignore

done

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #836 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #836      +/-   ##
=============================================
+ Coverage      37.73%   37.74%   +0.01%     
  Complexity       974      974              
=============================================
  Files            217      217              
  Lines           8364     8364              
  Branches        1002     1002              
=============================================
+ Hits            3156     3157       +1     
+ Misses          4828     4826       -2     
- Partials         380      381       +1
Impacted Files Coverage Δ Complexity Δ
...eata/core/rpc/netty/AbstractRpcRemotingClient.java 17.7% <0%> (+0.47%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e4606...c0c9e51. Read the comment docs.

@lovepoem lovepoem changed the title ues maven-compiler-plugin to revision the version and add mvnw script to unify the maven version Use maven-compiler-plugin to revision the version and add mvnw script to unify the maven version Apr 19, 2019
Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit ff86975 into apache:develop Apr 19, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
… to unify the maven version (apache#836)

* ues maven-compiler-plugin to revision the version 
* add mvnw script to unify the maven version
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants