fix #853 change delete undolog to batch delete #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #856 +/- ##
=============================================
+ Coverage 38.05% 38.29% +0.24%
- Complexity 1005 1013 +8
=============================================
Files 220 220
Lines 8452 8499 +47
Branches 1015 1023 +8
=============================================
+ Hits 3216 3255 +39
- Misses 4852 4859 +7
- Partials 384 385 +1
Continue to review full report at Codecov.
|
leizhiyuan
reviewed
Apr 19, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/AsyncWorker.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogManager.java
Outdated
Show resolved
Hide resolved
…ure_batch_delete_undolog
…hub-ygy/fescar into feature_batch_delete_undolog
slievrly
reviewed
Apr 23, 2019
| @@ -171,15 +175,33 @@ private void doBranchCommits() { | |||
| continue; | |||
| } | |||
| List<Phase2Context> contextsGroupedByResourceId = entry.getValue(); | |||
| Set<String> xids = new LinkedHashSet<>(UNDOLOG_DELETE_LIMIT_SIZE); | |||
| int xidSize = xids.size(); | ||
| int branchIdSize = branchIds.size(); | ||
| String batchDeleteSql = toBatchDeleteUndoLogSql(xidSize, branchIdSize,limitSize); | ||
| PreparedStatement deletePST = conn.prepareStatement(batchDeleteSql); |
There was a problem hiding this comment.
PreparedStatement will be invalid cause by the number different
slievrly
reviewed
Apr 23, 2019
| appendInParam(xidSize, sqlBuilder); | ||
| sqlBuilder.append(" AND xid IN "); | ||
| appendInParam(branchIdSize, sqlBuilder); | ||
| sqlBuilder.append(" LIMIT ").append(limitSize); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
change delete undolog to batch delete
Ⅱ. Does this pull request fix one issue?
fix #853
Ⅲ. Why don't you add test cases (unit test/integration test)?
UndoLogManagerTest
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews