Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GlobalTransactionScanner can't generate the proxy of dubbo:reference #866

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

zhangthen
Copy link
Contributor

@zhangthen zhangthen changed the title Check the proxy of dubbo. The GlobalTransactionScanner can't generate the proxy of dubbo:reference Apr 22, 2019
@codecov-io
Copy link

Codecov Report

Merging #866 into develop will decrease coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #866      +/-   ##
============================================
- Coverage      38.23%   38.2%   -0.03%     
  Complexity      1008    1008              
============================================
  Files            220     220              
  Lines           8446    8450       +4     
  Branches        1016    1018       +2     
============================================
- Hits            3229    3228       -1     
- Misses          4833    4836       +3     
- Partials         384     386       +2
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/spring/util/SpringProxyUtils.java 7.01% <25%> (+1.35%) 3 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 52.14% <0%> (-1.43%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d430e1...924d995. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangthen zhangthen merged commit 7661d54 into apache:develop Apr 23, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants