Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports service discovery with Etcd #869

Merged
merged 13 commits into from
Apr 29, 2019
Merged

Supports service discovery with Etcd #869

merged 13 commits into from
Apr 29, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

Supports service discovery with Etcd

Ⅱ. Does this pull request fix one issue?

fixes #812

Ⅲ. Why don't you add test cases (unit test/integration test)?

i have done integration test.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #869 into develop will decrease coverage by 0.5%.
The diff coverage is 0.76%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #869      +/-   ##
=============================================
- Coverage      38.29%   37.78%   -0.51%     
  Complexity      1033     1033              
=============================================
  Files            222      224       +2     
  Lines           8665     8795     +130     
  Branches        1051     1063      +12     
=============================================
+ Hits            3318     3323       +5     
- Misses          4953     5078     +125     
  Partials         394      394
Impacted Files Coverage Δ Complexity Δ
...discovery/registery/etcd/EtcdRegistryProvider.java 0% <0%> (ø) 0 <0> (?)
...covery/registery/etcd/EtcdRegistryServiceImpl.java 0% <0%> (ø) 0 <0> (?)
...java/io/seata/discovery/registry/RegistryType.java 38.46% <33.33%> (-0.67%) 2 <0> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.86% <0%> (+1.38%) 17% <0%> (ø) ⬇️
...ain/java/io/seata/core/rpc/netty/ShutdownHook.java 62.5% <0%> (+6.25%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad0855...fd59834. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangthen zhangthen merged commit b537ca9 into apache:develop Apr 29, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports service discovery with Etcd
6 participants