Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for decode regist rm request #872

Merged
merged 2 commits into from
Apr 23, 2019
Merged

fix bug for decode regist rm request #872

merged 2 commits into from
Apr 23, 2019

Conversation

leizhiyuan
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

no need

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

review it please

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #872 into develop will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #872      +/-   ##
=============================================
+ Coverage      38.26%   38.45%   +0.18%     
- Complexity      1013     1015       +2     
=============================================
  Files            220      220              
  Lines           8499     8504       +5     
  Branches        1023     1023              
=============================================
+ Hits            3252     3270      +18     
+ Misses          4861     4848      -13     
  Partials         386      386
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/core/protocol/RegisterRMRequest.java 70.14% <100%> (+2.4%) 8 <0> (ø) ⬇️
...eata/server/store/FileTransactionStoreManager.java 53% <0%> (-0.5%) 15% <0%> (ø)
...eata/core/rpc/netty/AbstractRpcRemotingClient.java 20.57% <0%> (+2.87%) 7% <0%> (ø) ⬇️
...ain/java/io/seata/core/rpc/netty/ShutdownHook.java 81.25% <0%> (+25%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc85f1...216b75e. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangthen zhangthen merged commit b31b824 into apache:develop Apr 23, 2019
@leizhiyuan leizhiyuan deleted the fix_bug_for_decode branch April 23, 2019 08:23
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants