Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #873 init default value for import config #874

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

github-ygy
Copy link
Contributor

Ⅰ. Describe what this PR did

init default value for import config

Ⅱ. Does this pull request fix one issue?

fix #873

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #874 into develop will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #874      +/-   ##
=============================================
+ Coverage      38.65%   38.66%   +0.01%     
  Complexity      1026     1026              
=============================================
  Files            220      220              
  Lines           8507     8507              
  Branches        1028     1028              
=============================================
+ Hits            3288     3289       +1     
+ Misses          4828     4826       -2     
- Partials         391      392       +1
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/core/rpc/netty/NettyBaseConfig.java 22.22% <66.66%> (ø) 2 <0> (ø) ⬇️
...eata/core/rpc/netty/AbstractRpcRemotingClient.java 17.7% <0%> (+0.47%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7661d54...1a2f453. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit a204553 into apache:develop Apr 24, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config does not init default value
5 participants