-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:support Statement#execute for SELECT_FOR_UPDATE #875
bugfix:support Statement#execute for SELECT_FOR_UPDATE #875
Conversation
Signed-off-by: hongwei yi <hongweiyi@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #875 +/- ##
=============================================
- Coverage 38.86% 38.67% -0.19%
+ Complexity 1028 1026 -2
=============================================
Files 220 220
Lines 8501 8498 -3
Branches 1024 1023 -1
=============================================
- Hits 3304 3287 -17
- Misses 4812 4823 +11
- Partials 385 388 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
RootContext.bind("123456:8091"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: hongwei yi hongweiyi@hotmail.com
Ⅰ. Describe what this PR did
support Statement#execute for SELECT_FOR_UPDATE
Ⅱ. Does this pull request fix one issue?
fixes #870
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've tested this in seata-examples. BTW, Seata need more test cases in the project.
Ⅳ. Describe how to verify it
Connection conn = dataSourceProxy.getConnection();
Statement stmt = conn.createStatement();
stmt.execute("select * from table where id=? for update");
Ⅴ. Special notes for reviews