-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #878 close the statement #879
Conversation
…ure_batch_delete_undolog
…hub-ygy/fescar into feature_batch_delete_undolog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #879 +/- ##
=============================================
- Coverage 37.2% 37.17% -0.03%
Complexity 1027 1027
=============================================
Files 225 225
Lines 8894 8906 +12
Branches 1066 1070 +4
=============================================
+ Hits 3309 3311 +2
- Misses 5199 5209 +10
Partials 386 386
Continue to review full report at Codecov.
|
rm-datasource/src/main/java/io/seata/rm/datasource/undo/UndoLogManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
when over,close the statement,if we use DruidPooledPreparedStatement,so wo can use cache
Ⅱ. Does this pull request fix one issue?
fix #878
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews