-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix NPE when use UNION ALL in select statement. #891
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #891 +/- ##
============================================
- Coverage 38.53% 38.33% -0.2%
+ Complexity 1035 1033 -2
============================================
Files 222 222
Lines 8662 8662
Branches 1048 1048
============================================
- Hits 3338 3321 -17
- Misses 4931 4948 +17
Partials 393 393
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix NPE when use UNION ALL in select statement.
Ⅱ. Does this pull request fix one issue?
fixes #794
Ⅲ. Why don't you add test cases (unit test/integration test)?
i have done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews