Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix NPE when use UNION ALL in select statement. #891

Merged
merged 6 commits into from
Apr 26, 2019
Merged

bugfix:fix NPE when use UNION ALL in select statement. #891

merged 6 commits into from
Apr 26, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

fix NPE when use UNION ALL in select statement.

Ⅱ. Does this pull request fix one issue?

fixes #794

Ⅲ. Why don't you add test cases (unit test/integration test)?

i have done integration testing.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #891 into develop will decrease coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #891     +/-   ##
============================================
- Coverage      38.53%   38.33%   -0.2%     
+ Complexity      1035     1033      -2     
============================================
  Files            222      222             
  Lines           8662     8662             
  Branches        1048     1048             
============================================
- Hits            3338     3321     -17     
- Misses          4931     4948     +17     
  Partials         393      393
Impacted Files Coverage Δ Complexity Δ
.../io/seata/rm/datasource/sql/SQLVisitorFactory.java 33.33% <100%> (ø) 2 <0> (ø) ⬇️
...ain/java/io/seata/core/rpc/netty/ShutdownHook.java 56.25% <0%> (-25%) 6% <0%> (-2%)
...eata/core/rpc/netty/AbstractRpcRemotingClient.java 17.22% <0%> (-3.35%) 7% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 53.47% <0%> (-1.39%) 17% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70827c4...01129f3. Read the comment docs.

Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit ab41b3a into apache:develop Apr 26, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException occured when using @GlobalTransactional and SQL with 'union all'
6 participants