Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some index check for decode #916

Merged
merged 6 commits into from
May 6, 2019
Merged

fix some index check for decode #916

merged 6 commits into from
May 6, 2019

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Apr 26, 2019

Ⅰ. Describe what this PR did

fix some logic bug when decode

Ⅱ. Does this pull request fix one issue?

fixes #909

Ⅲ. Why don't you add test cases (unit test/integration test)?

please review it, there some scenes, which member cloud be null,such as extraData,maybe I misunderstand it。

in this pr,I do not fix the merged message decoder

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #916 into develop will decrease coverage by 0.19%.
The diff coverage is 20.49%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #916     +/-   ##
============================================
- Coverage      37.17%   36.97%   -0.2%     
  Complexity      1033     1033             
============================================
  Files            225      225             
  Lines           8923     8908     -15     
  Branches        1079     1080      +1     
============================================
- Hits            3317     3294     -23     
+ Misses          5215     5212      -3     
- Partials         391      402     +11
Impacted Files Coverage Δ Complexity Δ
...o/seata/core/protocol/AbstractIdentifyRequest.java 47.31% <0%> (-2.69%) 12 <0> (ø)
...java/io/seata/core/protocol/MergedWarpMessage.java 72.72% <0%> (-1.19%) 8 <1> (ø)
...a/io/seata/core/rpc/netty/MessageCodecHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../seata/core/protocol/AbstractIdentifyResponse.java 45.83% <0%> (+0.93%) 4 <0> (ø) ⬇️
...ava/io/seata/core/protocol/MergeResultMessage.java 76.19% <0%> (-1.09%) 10 <1> (ø)
.../io/seata/core/protocol/AbstractResultMessage.java 66.03% <0%> (-0.04%) 14 <1> (ø)
...rotocol/transaction/AbstractBranchEndResponse.java 65.62% <33.33%> (-8.06%) 10 <0> (ø)
...java/io/seata/core/protocol/RegisterRMRequest.java 56.06% <33.33%> (-14.09%) 8 <1> (ø)
...protocol/transaction/AbstractBranchEndRequest.java 68.31% <41.93%> (-10.04%) 14 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a670592...48b2722. Read the comment docs.

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey to me.

Copy link
Contributor

@wgs13579 wgs13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangthen zhangthen merged commit b7a930d into apache:develop May 6, 2019
@leizhiyuan leizhiyuan mentioned this pull request May 9, 2019
1 task
@leizhiyuan leizhiyuan deleted the fix_decode_logic branch May 15, 2019 09:22
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indexOutOfBoundsException be thrown when read ByteBuf in AbstractBranchEndRequest line 230
5 participants