-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some index check for decode #916
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #916 +/- ##
============================================
- Coverage 37.17% 36.97% -0.2%
Complexity 1033 1033
============================================
Files 225 225
Lines 8923 8908 -15
Branches 1079 1080 +1
============================================
- Hits 3317 3294 -23
+ Misses 5215 5212 -3
- Partials 391 402 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix some logic bug when decode
Ⅱ. Does this pull request fix one issue?
fixes #909
Ⅲ. Why don't you add test cases (unit test/integration test)?
please review it, there some scenes, which member cloud be null,such as extraData,maybe I misunderstand it。
in this pr,I do not fix the merged message decoder
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews