Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the key type to String #923

Merged
merged 1 commit into from
Apr 26, 2019
Merged

change the key type to String #923

merged 1 commit into from
Apr 26, 2019

Conversation

nikyotensai
Copy link
Contributor

Ⅰ. Describe what this PR did

The return type of ctx.channel().remoteAddress() isn't String.I changed it.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #923 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #923      +/-   ##
============================================
- Coverage      38.51%   38.5%   -0.01%     
  Complexity      1035    1035              
============================================
  Files            222     222              
  Lines           8662    8664       +2     
  Branches        1048    1048              
============================================
  Hits            3336    3336              
- Misses          4933    4935       +2     
  Partials         393     393
Impacted Files Coverage Δ Complexity Δ
...main/java/io/seata/core/rpc/netty/RmRpcClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/io/seata/core/rpc/netty/TmRpcClient.java 29.16% <0%> (-0.18%) 12 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab41b3a...434422e. Read the comment docs.

Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 07eac3f into apache:develop Apr 26, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants