issue #936 add service load mechanism for TM #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/src/main/java/com/alibaba/fescar/server/coordinator/DefaultCoordinator.java
…try other application on the same resource.
…ormal SELECT SQL
# Conflicts: # test/src/main/java/com/alibaba/fescar/test/DataSourceBasicTest.java
# Conflicts: # rm-datasource/src/main/java/com/alibaba/fescar/rm/datasource/sql/druid/MySQLInsertRecognizer.java # rm-datasource/src/main/java/com/alibaba/fescar/rm/datasource/sql/struct/TableMetaCache.java # test/src/main/java/com/alibaba/fescar/test/DataSourceBasicTest.java
…m BranchSession
…n/branchsession exists while restoring
# Conflicts: # server/src/main/java/com/alibaba/fescar/server/session/FileBasedSessionManager.java
Codecov Report
@@ Coverage Diff @@
## develop #938 +/- ##
=============================================
+ Coverage 37.16% 37.19% +0.02%
- Complexity 1024 1026 +2
=============================================
Files 224 225 +1
Lines 8882 8892 +10
Branches 1065 1065
=============================================
+ Hits 3301 3307 +6
- Misses 5196 5199 +3
- Partials 385 386 +1
Continue to review full report at Codecov.
|
slievrly
reviewed
Apr 29, 2019
|
Who needs custom TransactionManager？Can you describe the usage scenarios？ |
TM and RM are core interfaces in Seata, I think it's better to take them forward to transaction standard, not just Java SDK. Implementations of TM and RM should be the endpoint for service providers of Seata standard. I hope this change will be the first step of making Seata as a standard.
|
wgs13579
reviewed
Apr 29, 2019
slievrly
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
issue #936 add service load mechanism for TM
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews