-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: support IN/BETWEEN WHERE clause recognize #965
bugfix: support IN/BETWEEN WHERE clause recognize #965
Conversation
Signed-off-by: hongwei yi hongweiyi@hotmail.com
Codecov Report
@@ Coverage Diff @@
## develop #965 +/- ##
=============================================
+ Coverage 37.11% 37.17% +0.05%
- Complexity 1027 1033 +6
=============================================
Files 225 225
Lines 8905 8923 +18
Branches 1070 1079 +9
=============================================
+ Hits 3305 3317 +12
- Misses 5212 5215 +3
- Partials 388 391 +3
Continue to review full report at Codecov.
|
@wenshao could I use SQLASTVisitor.visit(SQLExpr sqlExpr),just not analyze the implementation class SQLExpr? |
Use visit(SQLExpr) will get |
@hongweiyi do you know how to reproduce this problem? |
@xingfudeshi maybe u should use PreparedStatement instead of Statement |
@hongweiyi yes.should use prepared statement to reproduce this problem.thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
由于前期Seata社区治理规范问题部分代码作者未签署CLA,可能引发社区知识产权风险问题。请所有在Seata社区贡献过代码(包含:主项目、官网、samples和多语言项目等)的 contributor 帮忙在这个链接登录github账号签署相应的开发者CLA,https://cla-assistant.io/seata/seata 。2023.1.31 未签署CLA的代码将会被rewrite,拜托大家帮忙签一下。 |
Signed-off-by: hongwei yi hongweiyi@hotmail.com
Ⅰ. Describe what this PR did
support IN/BETWEEN WHERE clause recognize
Ⅱ. Does this pull request fix one issue?
fixes #867
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews