-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:some of the logs are incorrect #967
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #967 +/- ##
==========================================
Coverage 37.17% 37.17%
Complexity 1033 1033
==========================================
Files 225 225
Lines 8923 8923
Branches 1079 1079
==========================================
Hits 3317 3317
Misses 5215 5215
Partials 391 391 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix some of the logs are incorrect
Ⅱ. Does this pull request fix one issue?
fixes #966
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews