-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support consul as configuration center #988
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #988 +/- ##
==========================================
Coverage 38.26% 38.26%
Complexity 1046 1046
==========================================
Files 218 218
Lines 8694 8694
Branches 1083 1083
==========================================
Hits 3327 3327
Misses 4947 4947
Partials 420 420 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments
config/seata-config-consul/src/main/java/io/seata/config/consul/ConsulConfiguration.java
Outdated
Show resolved
Hide resolved
config/seata-config-consul/src/main/java/io/seata/config/consul/ConsulConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
config/seata-config-consul/src/main/java/io/seata/config/consul/ConsulConfiguration.java
Outdated
Show resolved
Hide resolved
config/seata-config-consul/src/main/java/io/seata/config/consul/ConsulConfiguration.java
Show resolved
Hide resolved
config/seata-config-consul/src/main/java/io/seata/config/consul/ConsulConfiguration.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Support consul as configuration center
Ⅱ. Does this pull request fix one issue?
fixes #885
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews