[SEDONA-120] Add ST_BuildArea function and tests #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnarb3
changed the title
krishnarb3
commented
Apr 25, 2022
| extends UnaryGeometryExpression with CodegenFallback { | ||
| assert(inputExpressions.length == 1) | ||
|
|
||
| override protected def nullSafeEval(geometry: Geometry): Any = { |
There was a problem hiding this comment.
Should this be a nullable function?
There was a problem hiding this comment.
Yes, this should be a nullable function. So no need to extend UnaryGeometryExpression
There was a problem hiding this comment.
Have updated the function and added null checks
krishnarb3
force-pushed
the
feature/ST_BuildArea
branch
from
b59e630
to
597f861
Compare
|
@jiayuasu Have fixed the test failures, seems to be a transient issue with the CI |
krishnarb3
force-pushed
the
feature/ST_BuildArea
branch
from
2978fd1
to
8722ccf
Compare
jiayuasu
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-120] Add ST_BuildArea function and tests.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?