[SEDONA-123] Fix check for invalid latitude/longitude values in ST_GeoHash

[brianrice2]

Did you read the Contributor Guide?

• Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

• Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-123. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?

Currently, ST_GeoHash checks for invalid latitude and longitude values (in GeometryGeoHashEncoder.scala):

• Longitude < -180
• Latitude < -90
• Longitude > 180
• Longitude > 90

This PR fixes the last comparison to check latitude instead of longitude.

How was this patch tested?

Added unit tests that fail before the fix (as well as some passing tests for similar boundary cases), implemented the fix suggested by Itamar, and tests now pass again.

Some screenshots during the process:

Test results after adding tests but before fix:

Test results after fix:

Did this PR include necessary documentation updates?

• No, this PR does not affect any public API so no need to change the docs.

[brianrice2]

Thanks @jiayuasu !