Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-468] Add notice for vertx 3.5.1 #642

Closed
wants to merge 1 commit into from
Closed

Conversation

yangbor
Copy link
Member

@yangbor yangbor commented Apr 10, 2018

This is related to SCB-459 which upgraded vertx to 3.5.1.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

This is related to SCB-459 which upgraded vertx to 3.5.1.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 87.481% when pulling 6935f7f on yangbor:master into 4f8f810 on apache:master.

@wujimin
Copy link
Contributor

wujimin commented Apr 12, 2018

vert-x3/vertx-web#906

will rollback to 3.5.0

@yangbor
Copy link
Member Author

yangbor commented Apr 12, 2018

Close this PR due to rollback to vertx 3.5.0

@yangbor yangbor closed this Apr 12, 2018
@WillemJiang
Copy link
Member

We need to revisit this issue once we upgrade the vertx version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants