Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-741 change payloads database type from varbinary(10240) to blob #226

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

SingleX
Copy link
Contributor

@SingleX SingleX commented Jul 18, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Jul 18, 2018

Coverage Status

Coverage decreased (-0.3%) to 93.023% when pulling aa893a2 on SingleX:SCB-741 into 2c1f574 on apache:master.

@WillemJiang
Copy link
Member

@SingleX
Thanks for the PR, We need to keep the stack trace size below 10240 at the same time.

@SingleX
Copy link
Contributor Author

SingleX commented Jul 20, 2018

@WillemJiang PR has been updated, please help to review it again, thanks

@WillemJiang WillemJiang merged commit be00cf4 into apache:master Jul 20, 2018
@SingleX SingleX deleted the SCB-741 branch July 20, 2018 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants