Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2432 #3050

Merged
merged 48 commits into from
Sep 17, 2019
Merged

Fixes #2432 #3050

merged 48 commits into from
Sep 17, 2019

Conversation

terrymanu
Copy link
Member

Fixes #2432.

terrymanu and others added 30 commits September 12, 2019 00:45
@terrymanu
for #2567, StandardRoutingEngine.reviseInsertValue() => setDataNode()
73d8ab8
@terrymanu
for #2567, change type of InsertValue.dataNodes
2e4f5b7
@terrymanu
for #2567, move dataNodes from InsertValue to ShardingCondition
5a7c8d9
@terrymanu
for #2567, change InsertParameterBuilder.insertParameterUnits from Li…
776b3da 
…st to Collection
@terrymanu
for #2567, remove getter for InsertParameterBuilder.insertParameterUnits
4398c4b
@terrymanu
for #2567, InsertParameterUnit => InsertParameterGroup
53c7ab6
@terrymanu
for #2567, InsertParameterUnit => InsertParameterGroup
1805c91
@terrymanu
for #2567, move InsertParameterBuilder from org.apache.shardingsphere…
3564b0c 
….core.rewrite.builder to org.apache.shardingsphere.core.rewrite.builder.insert
@terrymanu
for #2567, rename InsertParameterGroup to ValueParametersGroup
a015a6b
@terrymanu
for #2567, refactor ValueParametersGroup class from public to default
2d1cea0
@terrymanu
for #2567, add package of rewrite.builder.sql and rewrite.builder.par…
da10eb8 
…ameter
@terrymanu
for #2567, add package of rewrite.builder.parameter.single and rewrit…
8db7b8b 
…e.builder.parameter.group
@terrymanu
for #2567, rename InsertParameterBuilder to GroupParameterBuilder
601c4ca
@terrymanu
for #2567, generic GroupParameterBuilder
668c8eb
@terrymanu
for #2567, rename BaseParameterBuilder to StandardParameterBuilder
da2581d
@terrymanu
for #2567, rename GroupParameterBuilder to GroupedParameterBuilder
fb12619
@terrymanu
for #2567, remove derived encrypt column for sharding condition
7be6280
@terrymanu
for #2567, add SQLRewriteEngine.encryptInsertValues()
e71856c
@terrymanu
for #2567, inline SQLRewriteEngine.encryptOptimizedStatement()
2af6035
@terrymanu
for #2567, refactor ShardingInsertOptimizeEngine.getAllColumnNames()'…
d5ac519 
… return type
@terrymanu
for #2567, refactor generated key's rewrite logic, use isGenerated in…
ca9ed1d 
…stead of generateKey column judge whether to rewrite
@terrymanu
for #2567, add ShardingInsertOptimizeEngine.getInsertValues()
f327077
@terrymanu
for #2567, use statement and metadata to find generated key
20f15bb
@terrymanu
for #2567, add ShardingInsertOptimizeEngine.getColumnNames()
18398d9
@terrymanu
for #2567, refactor GeneratedKey
d61c3c0
@terrymanu
for #2567, refactor ShardingInsertOptimizedStatement's constructor
8cb7ed6
@terrymanu
for #2567, refactor EncryptInsertOptimizedStatement's constructor
dd870eb
@terrymanu
Merge pull request #1 from apache/dev
1f880c5 
merge from dev
@terrymanu
Merge branch 'dev' of https://github.com/apache/incubator-shardingsphere
a6699fc 
 into dev
@terrymanu
for #2567, add InsertClauseShardingConditionEngine.appendGeneratedKey…
431be26 
…Condition()
@terrymanu
for #2567, refactor WhereClauseEncryptConditionEngine.createEncryptCo…
7641feb 
…ndition()
@terrymanu
for #2567, add RewriteStatement
5fc38a5
@terrymanu
for #2567, use EncryptConditionOptimizedStatement for WhereEncryptCol…
331dca2 
…umnTokenGenerator
@terrymanu
for #2567, change signature of SQLTokenGenerator
0a16f6a
@terrymanu
for #2567, remove ConditionOptimizedStatement
bc24fae
@terrymanu
for #2567, remove ShardingConditionOptimizedStatement.encryptConditions
511dc3c
@terrymanu
for #2567, add InsertRewriteStatement
d6e87c7
@terrymanu
for #2567, add RewriteStatementFactory
7ba30c2
@terrymanu
for #2567, refactor ShardingUpdateOptimizeEngine
67885c0
@terrymanu
Merge branch 'dev' of https://github.com/apache/incubator-shardingsphere
8ccfb8b 
 into dev
@terrymanu
for #2567, refactor DALMergeEngine
8ac5a4b
@terrymanu
for #2567, compile for ShardingSelectOptimizedStatementTest
e1c6643
@terrymanu
Merge branch 'dev' of https://github.com/apache/incubator-shardingsphere
b0c5be7 
 into dev
@terrymanu
Merge branch 'dev' of https://github.com/apache/incubator-shardingsphere
2364fb8 
 into dev
@terrymanu
Merge branch 'dev' of https://github.com/apache/incubator-shardingsphere
75376ce 
 into dev
@terrymanu
revise #3025
3e8a8ab
@terrymanu
Merge branch 'dev' of https://github.com/apache/incubator-shardingsphere
82ceec5 
 into dev
@terrymanu
fix #2432
c9a8535
@coveralls
Copy link

Pull Request Test Coverage Report for Build 360

  • 8 of 17 (47.06%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 64.148%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/explain/ShardingCTLExplainBackendHandler.java 0 1 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java 0 2 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java 0 3 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java 1 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java 1 0.0%
Totals Coverage Status
Change from base Build 362: -0.01%
Covered Lines: 9390
Relevant Lines: 14638
💛 - Coveralls

@terrymanu terrymanu merged commit 2d19ab1 into apache:dev Sep 17, 2019
@cherrylzhao cherrylzhao mentioned this pull request Sep 18, 2019
Closed
@terrymanu terrymanu added this to the 4.0.0-RC3 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristaZero tristaZero tristaZero approved these changes

Assignees
No one assigned
Labels
feature: sharding type: refactor
Projects
None yet
Milestone
4.0.0-RC3
Development

Successfully merging this pull request may close these issues.

Redesign hint database only route
3 participants
@terrymanu @coveralls @tristaZero