Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Volunteer] format SQL to improve code readability in shenyu-admin. #3088

Closed
17 tasks done
midnight2104 opened this issue Mar 22, 2022 · 39 comments · Fixed by #3078, #3089, #3131, #3132 or #3153
Closed
17 tasks done

[Volunteer] format SQL to improve code readability in shenyu-admin. #3088

midnight2104 opened this issue Mar 22, 2022 · 39 comments · Fixed by #3078, #3089, #3131, #3132 or #3153
Labels
admin good first issue Good for newcomers level: easy status: volunteer wanted Extra attention is needed type: refactor

Comments

@midnight2104
Copy link
Contributor

midnight2104 commented Mar 22, 2022 •
edited

Description

Hi Community:
This PR is to format the current SQL, following the principle of right-aligning keywords (Uppercase) and left-aligning fields. I would like to make this task a good first issue so that new comers can get involved in handling the rest of the SQL file. Do you think it's a good idea?

for example:
before formatting:

select id, name, age from user where id = 1

after formatting

  SELECT id, 
         name, 
         age 
    FROM user
   WHERE id = 1

Task List

Notice: input about issue 3088 in your pr desc .
@midnight2104 midnight2104 added the status: volunteer wanted Extra attention is needed label Mar 22, 2022
@midnight2104 midnight2104 mentioned this issue Mar 22, 2022
Merged
@midnight2104 midnight2104 changed the title [Task] format SQL to improve code readability in shenyu-admin. [Volunteer] format SQL to improve code readability in shenyu-admin. Mar 22, 2022
@midnight2104 midnight2104 linked a pull request Mar 22, 2022 that will close this issue
[type:refactor] format SQL #3078
Merged
@midnight2104 midnight2104 reopened this Mar 22, 2022
@hutaishi
Copy link
Member

Can you randomly assign one of them to me? Thank you very much.

@midnight2104
Copy link
Contributor Author

Can you randomly assign one of them to me? Thank you very much.

thks for your contribution

@erdengk
Copy link
Contributor

erdengk commented Mar 22, 2022

hi，@midnight2104
Please assign me 17. user-role-sqlmap.xml

@midnight2104
Copy link
Contributor Author

hi，@midnight2104 Please assign me 17. user-role-sqlmap.xml

thks for your contribution

@shallwetalkge
Copy link
Contributor

hi, can you assign 16. shenyu-dict-sqlmap.xml to me,thank you

@midnight2104
Copy link
Contributor Author

midnight2104 commented Mar 22, 2022 •
edited

hi, can you assign 16. shenyu-dict-sqlmap.xml to me,thank you

Thks for your contribution.I look forward to hearing from you pr. Please contact me with any questions you may have.

@p8rtop
Copy link
Contributor

p8rtop commented Mar 22, 2022

Can you randomly assign one of them to me?

@midnight2104
Copy link
Contributor Author

Can you randomly assign one of them to me?

doen, 15. selector-sqlmap.xml

@totalo
Copy link
Member

totalo commented Mar 22, 2022 •
edited by midnight2104

Can you randomly assign one of them to me? Thank you.

ok, 13. rule-sqlmap.xml for you, thanks.

@lanseBlue
Copy link
Contributor

can you assign 14. selector-condition-sqlmap.xml to me thank you

@erdengk erdengk mentioned this issue Mar 22, 2022
Merged
@midnight2104
Copy link
Contributor Author

can you assign 14. selector-condition-sqlmap.xml to me thank you

Thks for your contribution.I'm looking forward to you PR. Please contact me with any questions you may have.

@UniverseInHeart
Copy link
Contributor

can you give me one not be format? thanks

hutaishi added a commit to hutaishi/shenyu that referenced this issue Mar 22, 2022
@hutaishi
format SQL to improve code readability in shenyu-admin. format auth-p…
e36f18b 
…aram-sqlmap.xml apache#3088
@hutaishi hutaishi mentioned this issue Mar 22, 2022
Merged
@totalo totalo mentioned this issue Mar 22, 2022
Merged
3 tasks
@Albertsirius
Copy link
Contributor

Can you assign one of files not formatted to me? thanks.

@shallwetalkge shallwetalkge mentioned this issue Mar 22, 2022
Merged
@midnight2104
Copy link
Contributor Author

Can you assign one of files not formatted to me? thanks.

11. role-sqlmap.xml for you, I'm looking forward to your PR.

@midnight2104
Copy link
Contributor Author

Can you assign one of files not formatted to me? thanks.

you can do 12. rule-condition-sqlmap.xml

@yu199195 yu199195 reopened this Mar 27, 2022
midnight2104 pushed a commit that referenced this issue Mar 28, 2022
@zhangcly
[ISSUE #3088] format SQL (#3132)
9cbb710
@midnight2104 midnight2104 reopened this Mar 28, 2022
@midnight2104 midnight2104 reopened this Mar 28, 2022
@Jingwugate
Copy link
Contributor

There are three unassigned tasks，Can you assign one to me？thank you

@midnight2104
Copy link
Contributor Author

There are three unassigned tasks，Can you assign one to me？thank you

yes. you can do 4. dashboard-user-sqlmap.xml

Jingwugate pushed a commit to Jingwugate/incubator-shenyu that referenced this issue Mar 30, 2022
format SQL, fix apache#3088
7bfb438
@Jingwugate Jingwugate mentioned this issue Mar 30, 2022
Merged
3 tasks
yu199195 pushed a commit that referenced this issue Mar 31, 2022
@Jingwugate
format SQL, fix #3088 (#3153)
47ccc8b 
Co-authored-by: huangtianbao <782933015@qq.com>
@yu199195 yu199195 reopened this Mar 31, 2022
@joker-zxs
Copy link
Contributor

Can you randomly assign one of them to me? Thank you very much.

@Mayank-KS
Copy link
Contributor

There are two unassigned tasks, can you assign one to me? Thank you

@selectbook selectbook mentioned this issue Apr 3, 2022
Merged
yu199195 pushed a commit that referenced this issue Apr 3, 2022
@selectbook
[type:refactor #3088] Format meta-data-sqlmap.xml (#3192)
7ea9bdf 
* format SQL to improve code readability in shenyu-admin.
format meta-data-sqlmap.xml

* format SQL to improve code readability in shenyu-admin.
format meta-data-sqlmap.xml
Mayank-KS added a commit to Mayank-KS/incubator-shenyu that referenced this issue Apr 5, 2022
@Mayank-KS
Merge pull request #1 from Mayank-KS/Mayank-KS-patch-1
caf0738 
[type: refactor apache#3088] Format data-permission-sqlmap.xml
@midnight2104
Copy link
Contributor Author

Can you randomly assign one of them to me? Thank you very much.

  1. plugin-handle-sqlmap.xml

@midnight2104
Copy link
Contributor Author

  • data-permission-sqlmap.xml

data-permission-sqlmap.xml

midnight2104 pushed a commit that referenced this issue Apr 7, 2022
@Mayank-KS
[type: refactor #3088] Format data-permission-sqlmap.xml (#3197)
83e1587 
* Format data-permission-sqlmap.xml

* Update data-permission-sqlmap.xml
@chineseGo8341
Copy link

have you finished the task assigned to you yet?plz let me know, I want to commit too

@midnight2104
Copy link
Contributor Author

have you finished the task assigned to you yet?plz let me know, I want to commit too

This has been done, there are more newcomer tasks later, stay tuned.

@midnight2104
Copy link
Contributor Author

Can you randomly assign one of them to me? Thank you very much.

hi, what's your progress? do you need help?

@joker-zxs
Copy link
Contributor

joker-zxs commented Apr 9, 2022 via email

@joker-zxs joker-zxs mentioned this issue Apr 9, 2022
Merged
@midnight2104
Copy link
Contributor Author

done

@ShawnSiao
Copy link
Contributor

ShawnSiao commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin good first issue Good for newcomers level: easy status: volunteer wanted Extra attention is needed type: refactor
Projects
None yet
Milestone
No milestone