Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE:3088] format SQL #3089

Merged
merged 2 commits into from Mar 23, 2022
Merged

[ISSUE:3088] format SQL #3089

merged 2 commits into from Mar 23, 2022

Conversation

erdengk
Copy link
Contributor

@erdengk erdengk commented Mar 22, 2022

// Describe your PR here; eg. Fixes #issueNo

fix #3088

@erdengk
Copy link
Contributor Author

erdengk commented Mar 23, 2022

@midnight2104
I looked at the already merged #3078 and #3098 . And made changes to my pr.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #3089 (f862aee) into master (4c4ec0b) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3089      +/-   ##
============================================
+ Coverage     58.93%   59.03%   +0.10%     
- Complexity     4394     4396       +2     
============================================
  Files           694      694              
  Lines         19934    19929       -5     
  Branches       1800     1797       -3     
============================================
+ Hits          11748    11765      +17     
+ Misses         7184     7164      -20     
+ Partials       1002     1000       -2     
Impacted Files Coverage Δ
...ugin/response/strategy/WebClientMessageWriter.java 78.57% <0.00%> (-2.28%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 83.73% <0.00%> (+6.50%) ⬆️
...henyu/admin/service/impl/UpstreamCheckService.java 63.49% <0.00%> (+7.93%) ⬆️
...yu/sync/data/http/refresh/AbstractDataRefresh.java 83.33% <0.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4ec0b...f862aee. Read the comment docs.

@yu199195
Copy link
Member

@erdengk used about to replace fix issueNo

@erdengk
Copy link
Contributor Author

erdengk commented Mar 23, 2022

@erdengk used about to replace fix issueNo

ok

@erdengk erdengk changed the title [type:refactor] format SQL [ISSUE:3088] format SQL Mar 23, 2022
@midnight2104 midnight2104 merged commit dee8725 into apache:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Volunteer] format SQL to improve code readability in shenyu-admin.
4 participants