Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SmartSql provider setting is not complete #2390

Closed
wu-sheng opened this issue Mar 20, 2019 · 4 comments
Closed

SmartSql provider setting is not complete #2390

wu-sheng opened this issue Mar 20, 2019 · 4 comments
Assignees
@liuhaoyang
Labels
bug Something isn't working and you are sure it's a bug!
Milestone
6.1.0

Comments

@wu-sheng
Copy link
Member

Ref #2387

We have four component-libraries.yaml for different purposes, need to sync the change to all of them. Also, should the mapping be there?
@wu-sheng wu-sheng added the bug Something isn't working and you are sure it's a bug! label Mar 20, 2019
@wu-sheng wu-sheng added this to the 6.1.0 milestone Mar 20, 2019
@wu-sheng
Copy link
Member Author

FYI @Ahoo-Wang

@Ahoo-Wang
Copy link
Contributor

@wu-sheng ok. I will pr this later.

@Ahoo-Wang
Copy link
Contributor

@wu-sheng I just find three component-libraries.yaml

oap-server\server-starter\src\main\resources\component-libraries.yml
oap-server\server-core\src\test\resources\component-libraries.yml
docker\config\component-libraries.yml

Can you help me find another one?

@wu-sheng
Copy link
Member Author

Yes. Only 3.

Ahoo-Wang added a commit to Ahoo-Wang/skywalking that referenced this issue Mar 21, 2019
@Ahoo-Wang
sync SmartSql provider setting -> fix apache#2390
65c5c60
@Ahoo-Wang Ahoo-Wang mentioned this issue Mar 21, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuhaoyang liuhaoyang

Labels
bug Something isn't working and you are sure it's a bug!
Projects
None yet
Milestone
6.1.0
Development

No branches or pull requests
3 participants
@Ahoo-Wang @wu-sheng @liuhaoyang