[Agent]Add a ProtectiveShieldMatcher to prevent match exception. #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
changed the title
|
This function is tested. Here is the auto_test report NOTE: Ignore the failure cases. because those cases are not perfect and the follow-up will improve it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, some frameworks and libraries use some binary codes tech too. From the community feedback, some of
them have compatible issues with byte-buddy core, which trigger "Can't resolve type description" exception.
So I build this protective shield by a nested matcher. When the origin matcher(s) can't resolve the type, the
SkyWalking agent ignores this types.
Notice: this ignore mechanism may miss some instrumentations, but at most cases, it's same. If missing happens, please pay attention to the WARNING logs.
FYI @peng-yongsheng @ascrutae
This related to #578 #555 , from the Raphew's help: raphw/byte-buddy#373