Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byte buddy can't resolve #4898

Closed
wants to merge 19 commits into from
Closed

Byte buddy can't resolve #4898

wants to merge 19 commits into from

Conversation

dagmom
Copy link
Contributor

@dagmom dagmom commented Jun 10, 2020

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Bug description.

Cannot resolve type description for org.mozilla0.javascript.Script

  • How to fix?

add ignore package

dagmom and others added 19 commits May 31, 2020 13:14
@dagmom
Bulk executed with failures，then log detail message
fafcf29
@dagmom
Merge branch 'master' into master
81d07c0
@dagmom
add new java sdk plugin : InfluxDB
dcc9a71
@dagmom
Merge branch 'master' into master
d28d344
@dagmom
Merge branch 'master' into master
d7a5d8a
@dagmom
plugin-test : influxdb-scenario
7121812
@dagmom
plugin-test : influxdb-scenario
2f99381 
support-version.list modify form old version and healthCheck use ping() api
@dagmom
plugin-test : upgrade influxdb-scenario support-version.list form 2.5…
2e0c634 
… ~ 2.17
@dagmom
plugin-test : add influxdb-scenario to Github Actions Job.
1296890
@dagmom
Merge branch 'master' into master
9caa661
@dagmom
raf check : exclude [jacoco] dir --> generated file from test agent p…
b151ad3 
…lugin scenarios
@dagmom
influxdb plugin : resolve raf problem and unit test case
ca855b4
@heyanlong @dagmom
[PHP-E2E] Support v8 (apache#4862)
5818b7e
@songzhendong @wu-sheng @dagmom
Remove nacos (apache#4867)
fa94bb5 
* Add annotation(AlarmCore.start)

* Upgrade nacos version to 1.2.0

* Revert "Upgrade nacos version to 1.2.0"

This reverts commit 4d7b06f.

* Update nacos version to 1.2.0(Solve the security problem of the old version of fastsjon)

* Recovery annotation

* Recovery annotation

* Update nacos version to 1.2.0

* Update tls_key_generate.sh path

Update tls_key_generate.sh path

* Add annotation(AlarmCore.start)

* Revert "Upgrade nacos version to 1.2.0"

This reverts commit 4d7b06f.

* Update nacos version to 1.2.0(Solve the security problem of the old version of fastsjon)

* Recovery annotation

* Recovery annotation

* Update tls_key_generate.sh path

* Execution Authority

* Remove nacos

* remove nacos code

* remove nacos

remove nacos

* remove nacos

remove nacos

* remove nacos

* remove nacos

Co-authored-by: songzhendong <289505773@qq.com>
Co-authored-by: songzhendong <songzhendong@xiaomi.com>
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
@dagmom
influxdb plugin : Some review comments fix
916a018
@dagmom
influxdb plugin : Some review comments fix
ef35816
@dagmom
Merge branch 'master' into master
dadb56e
@dagmom
influxdb plugin : remove since date
59a168d
@dagmom
[fix bug]Cannot resolve type description for org.mozilla0.javascript.…
3618ee1 
…Script
wu-sheng
wu-sheng reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make your commits clean. You should check out from the master branch into a new local branch, and change->pull request again. More importantly, we need your descriptions about your idea in the PR.

@wu-sheng wu-sheng added the TBD To be decided later, need more discussion or input. label Jun 10, 2020
@dagmom
Copy link
Contributor Author

dagmom commented Jun 14, 2020

ProtectiveShieldMatcher add feature for exclude some class with -Dskywalking_enhance_ignore_class_pattern, so we ignore some package

[Agent]Add a ProtectiveShieldMatcher to prevent match exception.

The problem is the same as above.
I'll use the new branch later.

@wu-sheng
Copy link
Member

@dagmom I was not talking about the feature, we need to make this PR basically first.

  1. CI should be right, but right now, there is conflicting file.
  2. Commit logs make me confusing. I recommend you to check out from the current master, and re-format the branch.

@wu-sheng
Copy link
Member

The most importantly, you mixed this PR and #4846 together. You should not do this. Please submit pull requests based on the separated branches.

@dagmom
Copy link
Contributor Author

dagmom commented Jun 14, 2020

The most importantly, you mixed this PR and #4846 together. You should not do this. Please submit pull requests based on the separated branches.

I see now, thank you for reminding me. @wu-sheng

I have new branch upstream/master on local, and I need confirm some details about org.mozilla.javascript.Script.

@wu-sheng
Copy link
Member

Take your time, it is not urgent. I just want to make you clear, why this PR is not reviewed.

When you are ready, feel free to open a clean PR.

@dagmom dagmom closed this Jun 14, 2020
@dagmom dagmom deleted the Byte-buddy-Can't-resolve branch June 22, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng left review comments

Assignees
No one assigned
Labels
TBD To be decided later, need more discussion or input.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagmom @wu-sheng @heyanlong @songzhendong