This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
doc_restructuring incl. [SPOT-163] #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated documentation, added separate sections for the data schema, the jar, and the ml_ops.sh script
rabarona
approved these changes
Jun 9, 2017
There was a problem hiding this comment.
I like the structure and the new content.
There are still a few things missing like the ones mentioned in SPOT-163 https://issues.apache.org/jira/browse/SPOT-163 and all the stuff in spot.conf regarding spot-ml.
I'm not saying this PR should resolve those, I'm just complementing the list.
Thanks.
|
I'll add some material to address SPOT-163 but what we probably really need somewhere is a "hey to configure your /etc/spot.conf" document |
added documentation on the parameters that ml_ops.sh grabs from /etc/spot.conf
Added documentation for how ml_ops.sh used the TOL parameter from /etc/spot.conf as a default value for the suspicion threshold.
|
+1 |
1 similar comment
|
+1 |
|
|
||
| The remaining instructions in this README file treat spot-ml in a stand-alone fashion that might be helpful for customizing and troubleshooting the | ||
| component. | ||
| These routines are contained in a jar file and there is a shell script ml_ops.sh for a simplified the invocation of the analyses. |
There was a problem hiding this comment.
There seems to be a typo here on new line 10, "...for a simplified the invocation..."
|
+1 (one type pointed out) |
|
'typo' that is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated documentation, added separate sections for the data schema, the jar, and the ml_ops.sh script