Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5 #110

Closed
jnioche opened this issue Mar 13, 2015 · 12 comments
Closed

Release 0.5 #110

jnioche opened this issue Mar 13, 2015 · 12 comments
Milestone

Comments

@jnioche
Copy link
Contributor

jnioche commented Mar 13, 2015

List the issues we want to include in the next release and do it

@DigitalPebble/committers-crawler what else?

@jakekdodd
Copy link
Contributor

The boring stuff, documentation =/

So #88 and #51, and maybe open a new issue for other things to document. Let's rank-order and choose the top 5 items or so? I'd propose

  1. Overview
  2. FetcherBolt description
  3. Parsing/outlink generation (Add/Improve documentation on parsing #124)
  4. Configuration
  5. Streams (Wiki on use of streams #51)

@jnioche jnioche added this to the 0.5 milestone Apr 8, 2015
@GuiForget
Copy link

I'll take a stab at the parsing one

@rkrombho
Copy link

rkrombho commented May 5, 2015

I'll try the Configuration one. May need some help and reviews for certain parameters as I don't yet understand all of them completely. Working on my fork and submit a PR when it's done.
I'll mark unclear parameters with ??? in the beginning of the description. They will require closer reviews by one of you.

@jnioche
Copy link
Contributor Author

jnioche commented May 6, 2015

Hi @rkrombho. Thanks for volunteering! Let me know when you're done with it and I'll review.

@rkrombho
Copy link

I'm pretty much done now with documenting Configuration options but it looks like I can't create pull-requests for wiki repositories.
https://github.com/rkrombho/storm-crawler/wiki/Configuration
(formating of the tables is not so nice)

Any proposal on how I should submit this to the project?

@jnioche
Copy link
Contributor Author

jnioche commented May 11, 2015

Hi

You should be able to edit the WIKI directly. Just add the Configuration
page and create a link from the main page

Thanks

j.

On 10 May 2015 at 12:23, Robert Krombholz notifications@github.com wrote:

I'm pretty much done now with documenting Configuration options but it
looks like I can't create pull-requests for wiki repositories.
https://github.com/rkrombho/storm-crawler/wiki/Configuration
(formating of the tables is not so nice)

Any proposal on how I should submit this to the project?


Reply to this email directly or view it on GitHub
#110 (comment)
.

@jnioche
Copy link
Contributor Author

jnioche commented May 11, 2015

Here's what's left to do before we can release 0.5

Moved to a future release :

@jakekdodd
Copy link
Contributor

#88 is done

@jnioche
Copy link
Contributor Author

jnioche commented May 20, 2015

Ok, so waiting for @GuiForget to comment on #124 and should be OK to release after that

@jnioche
Copy link
Contributor Author

jnioche commented May 27, 2015

no news from @GuiForget. Release 0.5 done

@jnioche jnioche closed this as completed May 27, 2015
@GuiForget
Copy link

Sorry @jnioche I haven't had the time to look at this these past weeks.

@jnioche
Copy link
Contributor Author

jnioche commented May 27, 2015

no probs @GuiForget !It's just documentation it can be fixed anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants