Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1163 - Change the GitHub templates for PRs to be more ASF specific #1185

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Apr 3, 2024

as the title says

@rzo1 rzo1 requested review from jnioche and pjfanning April 3, 2024 13:16
@jnioche
Copy link
Contributor

jnioche commented Apr 4, 2024

I would leave the info about the formatting

The code is properly formatted with 'mvn git-code-format:format-code -Dgcf.globPattern=**/*'

@rzo1
Copy link
Contributor Author

rzo1 commented Apr 4, 2024

I would leave the info about the formatting

The code is properly formatted with 'mvn git-code-format:format-code -Dgcf.globPattern=**/*'

Isn't the formatting executed as a pre-commit hook any way? But sure, let'S add it as another checkbox below

  • Is your initial contribution a single, squashed commit?

@rzo1 rzo1 merged commit a7ad1bb into main Apr 4, 2024
3 checks passed
@rzo1 rzo1 deleted the 1163 branch April 4, 2024 08:39
@rzo1
Copy link
Contributor Author

rzo1 commented Apr 4, 2024

Added the additional information regarding formatting as a checkbox. We can enhance the templates again, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants