New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-2987][Improve] Sort out and migrate the Code Style and Quality Guide. #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @VampireAchao Thank you for the contribution.
Some parts of the highlight look great.
I left a few of comments. PTAL in your free time.
Looking forward to the final edition.👍
cc @wolfboys
Co-authored-by: Yuepeng Pan <flinker@126.com>
Thx for ur review, I'll fix ASAP. |
# Conflicts: # community/submit_guide/code-style-and-quality-guide.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @VampireAchao Nice~
Thank you very much for the contribution.
LGTM +1.
now ping @wolfboys .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
apache/incubator-streampark#2987
apache/incubator-streampark#2986