Skip to content

Commit

Permalink
fixed logback.xml -> logback-spring.xml (#3717)
Browse files Browse the repository at this point in the history
* fixed logback.xml -> logback-spring.xml

* modify livenessProbe & readinessProbe use httpGet
modify volumeMounts streampark-default-config-volume mountPath /usr/local/service/streampark/conf > /streampark/conf

* fixed readinessProbe Values.spec.livenessProbe.containerPort > Values.spec.readinessProbe.containerPort

---------

Co-authored-by: zhangmz <soulmz@dingtalk.com>
  • Loading branch information
soulmz and zhangmz committed May 19, 2024
1 parent 7d0d1e6 commit ed46fd0
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 7 deletions.
20 changes: 15 additions & 5 deletions helm/streampark/templates/streampark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,13 @@ spec:
command: ["bash","-c","bash ./bin/streampark.sh start_docker"]
{{- if .Values.spec.livenessProbe.enabled }}
livenessProbe:
exec:
command: [ "curl", "-s", "http://localhost:10000/actuator/health/liveness" ]
httpGet:
{{- if .Values.spec.livenessProbe.containerPort }}
port: {{ .Values.spec.livenessProbe.containerPort }}
{{- else }}
port: {{ .Values.spec.containerPort }}
{{- end }}
path: {{ .Values.spec.livenessProbe.livenessPath }}
initialDelaySeconds: {{ .Values.spec.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.spec.livenessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.spec.livenessProbe.timeoutSeconds }}
Expand All @@ -73,8 +78,13 @@ spec:
{{- end }}
{{- if .Values.spec.readinessProbe.enabled }}
readinessProbe:
exec:
command: [ "curl", "-s", "http://localhost:10000/actuator/health/readiness" ]
httpGet:
{{- if .Values.spec.readinessProbe.containerPort }}
port: {{ .Values.spec.readinessProbe.containerPort }}
{{- else }}
port: {{ .Values.spec.containerPort }}
{{- end }}
path: {{ .Values.spec.readinessProbe.readinessPath }}
initialDelaySeconds: {{ .Values.spec.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.spec.readinessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.spec.readinessProbe.timeoutSeconds }}
Expand All @@ -83,7 +93,7 @@ spec:
{{- end }}
volumeMounts:
- name: streampark-default-config-volume
mountPath: /usr/local/service/streampark/conf
mountPath: /streampark/conf
resources:
{{- toYaml .Values.spec.resources | nindent 12 }}
volumes:
Expand Down
8 changes: 6 additions & 2 deletions helm/streampark/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ spec:
## More info: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
livenessProbe:
enabled: true
initialDelaySeconds: "90"
containerPort: 10000
livenessPath: "/actuator/health/liveness"
initialDelaySeconds: "45"
periodSeconds: "30"
timeoutSeconds: "20"
failureThreshold: "3"
Expand All @@ -97,7 +99,9 @@ spec:
## More info: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
readinessProbe:
enabled: true
initialDelaySeconds: "90"
containerPort: 10000
readinessPath: "/actuator/health/liveness"
initialDelaySeconds: "45"
periodSeconds: "30"
timeoutSeconds: "20"
failureThreshold: "3"
Expand Down

0 comments on commit ed46fd0

Please sign in to comment.