Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] expose local mode in web-ui #2445

Closed
wants to merge 1 commit into from

Conversation

zhoulii
Copy link
Member

@zhoulii zhoulii commented Mar 15, 2023

What changes were proposed in this pull request

Issue Number: close #2444

Verifying this change

Manually verified the change by testing locally, including:
- select local mode when editting job on the web-ui;
- cancel local job;
- close minicluster when job is done or terminated;
- trigger savepoint for local job;
- jump to Flink Web UI in detail tab;

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@wolfboys
Copy link
Member

hi zhoulii:
Thanks for your contribution, local mode just a mini-cluster, Only for local testing, It is not difficult to support this function. This mode cannot be used in production, If the user use this mode, it is likely to cause production accidents, If this feature is supported, it will bring confusion to users,so my side is -1

@zhoulii
Copy link
Member Author

zhoulii commented Mar 15, 2023

Hi @wolfboys ,Thanks for your explanation. I understand what's your concren, minicluster is really not suitable for production. But it provides a quick way to vertify your code. We can expose it and give some reminders, like this , and give the choice to users.

@zhoulii
Copy link
Member Author

zhoulii commented Mar 15, 2023

Since this is not an urgent demand, I will close this pr and related issue one day later if no more comments received. We can reopen it if necessary, thanks again for the reply @wolfboys .

@wolfboys
Copy link
Member

wolfboys commented Mar 15, 2023

Since this is not an urgent demand, I will close this pr and related issue one day later if no more comments received. We can reopen it if necessary, thanks again for the reply @wolfboys .

quick way to verify code and interactive query already in roadmap, we plan to integrate flinksql-gateway, see #2274, your can send email to dev@streampark.apache.org or follow our WeChat official Account or Twitter, so we can have a better discussion

@zhoulii zhoulii closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] expose local mode in web-ui
2 participants