Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove delete user function and add transfer resource of user function #2734

Merged
merged 12 commits into from May 8, 2023

Conversation

VampireAchao
Copy link
Contributor

@VampireAchao VampireAchao commented May 7, 2023

What changes were proposed in this pull request

Issue Number: close #2712

Brief change log

  1. Requirement:
  • The administrator cancels the user deletion function and replaces it with disabling users.

image

  1. Detailed logic:
  • The administrator cancels the user deletion function.
  • When the user account is disabled, it cannot own resources (application and project ownership)
  • Add resource transfer function to transfer disabled user resources to new users

8f04aebad699a2e235467432a89f976

Verifying this change

Change the user's status when the user has resources.

This change is already covered by existing tests, such as UserServiceTest.

This change added tests and can be verified as follows:

  1. testLockUser in UserServiceTest
  • This unit test covers different scenarios for locking and unlocking a user when they have no resources, as well as locking a user when they have resources and checking the different return results.
  1. testTransferResource in UserServiceTest
  • This unit test involves transferring a user's resources to another person.

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)
    no

@VampireAchao
Copy link
Contributor Author

I will modify the modal

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 8056c17 into apache:dev May 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] job cannot be displayed
2 participants