Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] Properly carry vue-vben-admin's license info #3689

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[Improve] Properly carry vue-vben-admin's license info #3689

merged 1 commit into from
Apr 29, 2024

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Apr 29, 2024 •
edited

  1. Carry the LICENSE file from https://github.com/vbenjs/vue-vben-admin/blob/main/LICENSE.
  2. Remove the misleading "streampark-console/streampark-console-webapp/LICENSE" and add more comprehensive words.

This is followed by #3691.

@tisonkun
[Improve] Properly carry vue-vben-admin's license info
c07effb 
Signed-off-by: tison <wander4096@gmail.com>
wangsizhu0504
wangsizhu0504 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@wangsizhu0504 wangsizhu0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the mentor's guidance.

@wangsizhu0504 wangsizhu0504 merged commit 3ed3a7f into apache:dev Apr 29, 2024
7 of 8 checks passed
@tisonkun tisonkun deleted the vue-vben-admin-license branch April 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangsizhu0504 wangsizhu0504 wangsizhu0504 approved these changes

Assignees
No one assigned
Labels
WEB UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tisonkun @wangsizhu0504