Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL search query search string shouldn't be case sensititive #11585

Closed
hughhhh opened this issue Nov 5, 2020 · 4 comments · Fixed by #11702
Closed

SQL search query search string shouldn't be case sensititive #11585

hughhhh opened this issue Nov 5, 2020 · 4 comments · Fixed by #11702
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead good first issue Good first issues for new contributors

Comments

@hughhhh
Copy link
Member

hughhhh commented Nov 5, 2020

Screenshot

N/A

Description

Right now whenever users search for queries they are case sensitive. We should remove this to allow users to put in term with any cases

Design input

[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review. If this includes a design proposal,
include the label design:suggest]

@hughhhh hughhhh added good first issue Good first issues for new contributors sqllab #bug:cosmetic Cosmetic/layout/design tweak needed labels Nov 5, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.70. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Nov 5, 2020
@willbarrett
Copy link
Member

@nytai @dpgaspar this might be good to address in the new Query Search system.

@nytai
Copy link
Member

nytai commented Nov 18, 2020

I believe it's case insensitive, I'll double check though

@nytai nytai linked a pull request Nov 18, 2020 that will close this issue
6 tasks
@nytai
Copy link
Member

nytai commented Nov 18, 2020

Yup, should be fixed when ☝️ is merged and released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead good first issue Good first issues for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@willbarrett @nytai @hughhhh and others