Enable color consistency in a dashboard #7086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [date-filter] Adding minus infinity * Update DateFilterControl.jsx eqeqeq
* added more functionalities for query context and object. * fixed cache logic * added default value for groupby * updated comments and removed print
…6857) * auto-set 'Is Temporal' to true where column_name == '__time' * Adress comments * lint * clarifying name and comments
* initial commit for VIZ-58 * address @kristw's comments * per @mistercrunch's comment to use a static list for now * fix javascript test errors * fix lint errors * per @betodealmeida's comments * remove unnecessary loop
* Adding extraOverrides to line chart * Updating extraOverrides to fit with more cases * Moving extraOverrides to index.js * Removing webpack-merge in package.json * Fixing metrics control clearing metric
* feat: bump @superset-ui versions * refactor: remove visUtils and use @superset-ui/dimension * refactor: remove dead code * fix: update package lock * fix: lint two files * fix: package lock
…harts added by edit mode (apache#6980) UIC-1046
This PR removes the iteration over charts, dashboards and saved queries to create tags in the original migration, leaving only the logic to create the tags and the tagged objects tables. Tested locally by running `superset db downgrade` to revert to the previous migration and then running `superset db upgrade` to the current version.
* Bump sqlalchemy dep * Addressing comments
…d by sonarqube report as a critical vulnerability (apache#7034)
* [api/v1][query_obj] add default prequeries array * [api/v1][query_obj] fix prequeries type
* User can turn off download - export csv from a dashboard * Revert changes in the backendSync * Fix space error in the MenuItem Export CSV
* Download RAT binary via HTTPS, not HTTP * Merge branch 'patch-1' of github.com:hajdbo/incubator-superset into patch-1
khtruong
changed the title
This PR includes the following layout and css tweaks: - Using flex to layout the north and south sub panes of query pane so resizing works properly in both Chrome and Firefox - Removal of necessary wrapper divs and tweaking of css in sql lab so we can scroll to the bottom of both the table list and the results pane - Make sql lab's content not overflow vertically and layout the query result area to eliminate double scroll bars - css tweaks on the basic.html page so the loading animation appears in the center of the page across the board
* Add HTTP Basic Auth for Druid (Issue apache#4776) This should resolve [Issue apache#4776](apache#4776) Add HTTP Basic Auth to the Druid Broker. Signed-off-by: Don Bowman <don@agilicus.com> * Encrypt broker password in database Signed-off-by: Don Bowman <don@agilicus.com> * Merge from master, new migration needed Signed-off-by: Don Bowman <don@agilicus.com> * Do not expose hashed druid basic auth password * docs: add description_columns for druid basic auth
…he#7054) * Apache Releases https://github.com/mistercrunch/superset/blob/apache-releases/RELEASING.md#apache-releases * npm run prod -> npm run build
Codecov Report
@@ Coverage Diff @@
## lyftga #7086 +/- ##
==========================================
- Coverage 64.34% 64.18% -0.16%
==========================================
Files 422 425 +3
Lines 20520 20672 +152
Branches 2253 2269 +16
==========================================
+ Hits 13204 13269 +65
- Misses 7183 7270 +87
Partials 133 133
Continue to review full report at Codecov.
|
…#7090) * fix(useless-self-assignment): correct useless-self-assignment * udated code formatting
I left this behind on a previous PR, and it gets kind of crazy on large SQL statements, so decided it's probably a good thing to clean this up.
Package maintainers should really never delete packages, but it appears this happened with croniter and resulted in breaking our builds. This PR bumps to a more recent existing version of the library
* Exclude venv for python linter to ignore * Fix NaN error
* Add ability to change font sizes in Big Number * rename big number to header * Add comment to clarify font size values
(cherry picked from commit 7f3c145)
khtruong
force-pushed
the
VIZ-335
branch
2 times, most recently
from
87c3be8
to
c38ab70
Compare
|
Closing because I got my branch in a weird state and it was just easier to create a new branch. Refer to this PR: #7135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want color consistency so that when users revisit dashboards, colors remain the same for metrics.
Currently, we follow a general algorithm to assign colors to metrics but it can lead to inconsistency. The user first picks a color scheme. Then we iterate through the list of data values and assign a color to it in a sequential manner. The color assignments are stored for the current session. If more values are added, we continue down the list of colors that are part of the scheme. If a user removes a value, all the other values keep their color association because we have stored this information. When the user saves the chart or dashboard, we do not save the color assignments. Thus when the user revisits the chart or dashboard, the color assignments may change because it iterates through the values displayed in the chart or dashboard and re-assigns their colors again. This can cause some confusion when users revisit their visualizations.
This PR enforces color consistency in dashboards so that when users revisit dashboards, the same colors are applied to metrics on each visit. Note that this will not apply until the owner edits his or her dashboard and selects/saves a color scheme.
I am putting out a PR while I add unit tests.