-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User can turn off download - export csv from a dashboard #6821
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6821 +/- ##
==========================================
- Coverage 56.16% 56.16% -0.01%
==========================================
Files 527 527
Lines 23376 23379 +3
Branches 2794 2796 +2
==========================================
+ Hits 13130 13131 +1
- Misses 9836 9838 +2
Partials 410 410
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #6821 +/- ##
==========================================
- Coverage 56.16% 56.16% -0.01%
==========================================
Files 527 527
Lines 23376 23379 +3
Branches 2794 2796 +2
==========================================
+ Hits 13130 13131 +1
- Misses 9836 9838 +2
Partials 410 410
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding variable
supersetCanCSV
to check if the user has permission to download CSV in the dashboard.Superset has a permission
can_csv
to check if we are allowed to export CSV or not.This commit should fix the issues #6116, #6110
Screenshots:
Admin user with can_csv permission can export csv.
Remove can_csv permission from Gamma role.
Gamma user access to dashboard options without the export csv option.