fix: adds pagination/infinite scroll to owners select on DashboardList and ChartList #10035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10035 +/- ##
==========================================
- Coverage 70.47% 68.86% -1.61%
==========================================
Files 583 584 +1
Lines 31019 31061 +42
Branches 3175 3182 +7
==========================================
- Hits 21861 21391 -470
- Misses 9049 9561 +512
Partials 109 109
Continue to review full report at Codecov.
|
nytai
commented
Jun 10, 2020
| @@ -347,10 +348,6 @@ describe('ListView with new UI filters', () => { | |||
| expect(wrapper.find(ListViewFilters)).toHaveLength(1); | |||
| }); | |||
|
|
|||
| it('fetched selects if function is provided', () => { | |||
There was a problem hiding this comment.
fetching now happens on select open/click. This is really hard to simulate via enzyme.
etr2460
reviewed
Jun 11, 2020
| @@ -198,7 +198,7 @@ const ListView: FunctionComponent<Props> = ({ | |||
| {bulkActions.map(action => ( | |||
| // @ts-ignore | |||
| <MenuItem | |||
| key={action.key} | |||
| key={action.key || action.name} | |||
There was a problem hiding this comment.
when will an action not have a key?
There was a problem hiding this comment.
I added this after getting a react error in tests. I've updated the BulkAction type and made key a required field. Also fixed the test
rusackas
approved these changes
Jun 17, 2020
nytai
force-pushed
the
tai/async-paginate-react-select
branch
from
98819e1
to
d65341f
Compare
6 tasks
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
followup from #9989
This PR adds infinite scroll via
react-select-async-paginate(same author asreact-select).TEST PLAN
ADDITIONAL INFORMATION