feat: Switch from nosetest to pytest

[bkyryliuk]

Changed test runner from nosetests to pytest
Tox locally seems to be working just fine and contributor instructions don't need to change.

Changes:

1. changed runner from nosetests to pytest
2. added pytest.ini for global pytest controls
3. updated run.sh and tox not to compute the coverage
4. updated test classes to start with Test_ and not too have init method

Naming conventions:

• https://docs.pytest.org/en/reorganize-docs/new-docs/user/naming_conventions.html#:~:text=File%20names%20should%20start%20or,Test%E2%80%9D%2C%20as%20in%20TestExample%20.&text=To%20change%20how%20pytest%20recognises,Advanced%20%2D%20configuring%20test%20discovery).

Testing

• Made sure that test coverage stays the same
• Validated that tests match to the nosetest via pytest --collect-only

[ktmud]

1. Code coverage is missing
   

2. Might want to remove nosetests from pip dependencies and clean this up as well.

[bkyryliuk]

1. Code coverage is missing
   
2. Might want to remove nosetests from pip dependencies and clean this up as well.

@ktmud good catch. Will do the 1. As for point 2 - I changed nosetests there to the tool:pytest

[ktmud]

Ah, sorry for missing that. Are those nosetests options in setup.cfg also valid for pytest as well?

[bkyryliuk]

Ah, sorry for missing that. Are those nosetests options in setup.cfg also valid for pytest as well?

@ktmud taking into account that we want to modify the local tests vs CI behavior that section is probably not needed.
Can you take another look at the PR?
I've modified it to run test coverage only in the python_tests.sh

[ktmud]

Code LGTM! Do you know why did Codecov say overall coverage dropped by 17.79%?

[ktmud]

Do we want coverage for this file as well? I don't think it's needed but it was covered in previous setup.

[bkyryliuk]

my preference is not to count it, to me this is more a fixture setup rather than an actual test.
However do not have a preference here.

[bkyryliuk]

https://codecov.io/gh/apache/incubator-superset/pull/10177/commits - looks like it was the reason for dropped coverage - will keep playing with it

[bkyryliuk]

Code LGTM! Do you know why did Codecov say overall coverage dropped by 17.79%?
old run, will try to see how can I trigger it again

[bkyryliuk]

@ktmud and @john-bodley could you please take another look?
I've missed some tests in the original implementation and had to do extra changes to the test class names.

[ktmud]

Codecov seems to be stuck at "waiting for CI to complete", just like in #10142 . If you can get it fixed, that'd be great. If not, we can probably just merge this as is and see if it's a recurring issue in the next PR.

There were also some deprecation warnings in the logs that might worth fixing (could be in another PR):

tests/security_tests.py::TestRolePermission::test_set_perm_slice
  /home/runner/work/incubator-superset/incubator-superset/tests/security_tests.py:425: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(slice.schema_perm, table.schema_perm)

[bkyryliuk]

Codecov seems to be stuck at "waiting for CI to complete", just like in #10142 . If you can get it fixed, that'd be great. If not, we can probably just merge this as is and see if it's a recurring issue in the next PR.

There were also some deprecation warnings in the logs that might worth fixing (could be in another PR):

tests/security_tests.py::TestRolePermission::test_set_perm_slice
  /home/runner/work/incubator-superset/incubator-superset/tests/security_tests.py:425: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(slice.schema_perm, table.schema_perm)

@ktmud this is interesting, report is generated on their side: https://codecov.io/gh/apache/incubator-superset/pull/10177
however was not send to update the PR, will amend the PR and see if it fixes it.

[codecov-commenter]

Codecov Report

Merging #10177 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10177      +/-   ##
==========================================
- Coverage   65.84%   65.69%   -0.15%     
==========================================
  Files         594      594              
  Lines       31486    31492       +6     
  Branches     3222     3223       +1     
==========================================
- Hits        20732    20689      -43     
- Misses      10574    10623      +49     
  Partials      180      180              

Flag	Coverage Δ
#javascript	59.42% <ø> (+<0.01%)	⬆️
#python	70.16% <ø> (-0.26%)	⬇️

Impacted Files	Coverage Δ
superset/examples/birth_names.py	77.77% <0.00%> (-22.23%)	⬇️
superset/examples/unicode_test_data.py	81.63% <0.00%> (-18.37%)	⬇️
superset/examples/energy.py	84.61% <0.00%> (-15.39%)	⬇️
superset/examples/world_bank.py	84.61% <0.00%> (-15.39%)	⬇️
superset/examples/helpers.py	85.00% <0.00%> (-12.50%)	⬇️
superset/examples/css_templates.py	89.47% <0.00%> (-10.53%)	⬇️
superset/dashboards/dao.py	91.26% <0.00%> (-0.98%)	⬇️
superset/cli.py	39.72% <0.00%> (-0.35%)	⬇️
...erset-frontend/src/SqlLab/components/ResultSet.jsx	70.24% <0.00%> (-0.10%)	⬇️
superset/views/database/api.py	87.50% <0.00%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4342c33...d083dc9. Read the comment docs.