build: enable test coverage only for CI #10142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So people who run tests locally don't have to scroll.
ktmud
force-pushed
the
nosetests-coverage
branch
from
45f98f2
to
e90726a
Compare
|
Hmm, Codecov still not reporting coverage, even though it looks normal from build logs. Close and re-open to see if it fixes the issue. |
|
I'm a big fan of this change. Once codecov is working on this branch count me in for an approval. |
|
Codecov still acting weird. Close in favor of #10177 . @bkyryliuk could you make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently Python unit tests via
nosetestsalways output test coverage, but there's no way to disable it. The very long coverage report is quite annoying and makes it more difficult to scan test errors, especially when you just want to run a single test.This PR disables test coverage by default, but reenables it for CI jobs that run the full test suite.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See SUMMARY
TEST PLAN
Make sure test coverage still reported for GitHub PRs.
ADDITIONAL INFORMATION