Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datatable dependencies for pivot-table in dev #10205

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jun 30, 2020

SUMMARY

#10113 removed jquer.DataTables and the webpack hack to make it work for dev servers (npm run dev). But it is still used by the Pivot Table chart.

This will throw a "can't access $ of undefined" error in a clean build.

This should have been catched by Cypress tests for visualizations, but they were not turned on.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

ADDITIONAL INFORMATION

@ktmud
Copy link
Member Author

ktmud commented Jun 30, 2020

Cache hit miss could be caused by racing CI jobs on both push and `pull_request. Close and reopen to see it fixes it.

@ktmud ktmud closed this Jun 30, 2020
@ktmud ktmud reopened this Jun 30, 2020
@kristw kristw merged commit 9664705 into apache:master Jun 30, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants