build: enable Cypress tests for visualizations #10206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
etr2460
approved these changes
Jul 1, 2020
Comment on lines
+60
to
+62
| // Number of circles are pretty unstable when there are a lot of circles | ||
| // Since main functionality is already covered in fitler test below, | ||
| // skip this test untill we find a solution. |
There was a problem hiding this comment.
if this test is unstable and we already cover main functionality, should we delete the test? Seems like there's not much point in keeping it around tbh
There was a problem hiding this comment.
Part of me still wants to find the root cause of this instability, even though I may never find time to do it, but it doesn't hurt to keep this here as a reminder?
6 tasks
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#10158 Tried to re-enable Cypress tests for visualizations, but missed one critical step: update the CI to include them.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Make sure the visualization tests show up in CI run logs.
ADDITIONAL INFORMATION