Skip to content

Commit

Permalink
build: enable Cypress tests for visualizations (apache#10206)
Browse files Browse the repository at this point in the history
  • Loading branch information
ktmud authored and auxten committed Nov 20, 2020
1 parent 241c89b commit e9e1266
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bashlib.sh
Expand Up @@ -189,7 +189,7 @@ cypress-run-all() {
nohup flask run --no-debugger -p $port > "$flasklog" 2>&1 < /dev/null &
local flaskProcessId=$!

cypress-run "*/*"
cypress-run "*/**/*"

# Upload code coverage separately so each page can have separate flags
# -c will clean existing coverage reports, -F means add flags
Expand Down
Expand Up @@ -57,7 +57,10 @@ describe('Visualization > Bubble', () => {
cy.route('POST', '/superset/explore_json/**').as('getJson');
});

it('should work', () => {
// Number of circles are pretty unstable when there are a lot of circles
// Since main functionality is already covered in fitler test below,
// skip this test untill we find a solution.
it.skip('should work', () => {
verify(BUBBLE_FORM_DATA);
// number of circles = 214 rows
cy.get('.chart-container svg .nv-point-clips circle').should(
Expand Down
Expand Up @@ -103,6 +103,7 @@ describe('Visualization > Table', () => {
it('Test table with columns and row limit', () => {
const formData = {
...VIZ_DEFAULTS,
query_mode: 'raw',
all_columns: ['name'],
metrics: [],
row_limit: 10,
Expand All @@ -117,6 +118,7 @@ describe('Visualization > Table', () => {

const formData = {
...VIZ_DEFAULTS,
query_mode: 'raw',
all_columns: ['name', 'state', 'ds', 'num'],
metrics: [],
row_limit: limit,
Expand Down

0 comments on commit e9e1266

Please sign in to comment.