fix: better backward compatibility for table viz #10219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yep |
|
also fixes #10215 |
3 tasks
etr2460
approved these changes
Jul 1, 2020
Comment on lines
+106
to
+107
| // should still work when query_mode is not-set/invalid | ||
| query_mode: undefined, |
There was a problem hiding this comment.
should we keep the old test case and add the new one?
There was a problem hiding this comment.
There is another test below that sets query_mode with a value. Can make it more explicit though.
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bump table viz to v0.14.5 (not released yet) to change default query mode from
aggregatetonullso it can have better backward compatibility. Currently existing tables in the oldNOT GROUP BYmode will not open theQuery Mode: Rawtab by default.Accompanying superset-ui PR: apache-superset/superset-ui#659
This bug was actually captured by #10206, but I was lazy and went with an easier fix.
Update: also fixes #10215 .
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Open an existing table chart querying raw columns:
Currently received:
Expected:
TEST PLAN
ADDITIONAL INFORMATION