Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better backward compatibility for table viz #10219

Merged
merged 2 commits into from Jul 1, 2020
Merged

fix: better backward compatibility for table viz #10219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8dedae
fix: better backward compatibility for table viz
ktmud Jul 1, 2020
2a22990
Bump npm lock
ktmud Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.js
View file
Open in desktop
Expand Up @@ -103,7 +103,8 @@ describe('Visualization > Table', () => {
it('Test table with columns and row limit', () => {
const formData = {
...VIZ_DEFAULTS,
query_mode: 'raw',
// should still work when query_mode is not-set/invalid
query_mode: undefined,
Comment on lines +106 to +107
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep the old test case and add the new one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another test below that sets query_mode with a value. Can make it more explicit though.

all_columns: ['name'],
metrics: [],
row_limit: 10,
Expand Down
14 changes: 7 additions & 7 deletions superset-frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion superset-frontend/package.json
View file
Open in desktop
Expand Up @@ -85,7 +85,7 @@
"@superset-ui/legacy-plugin-chart-sankey": "^0.14.1",
"@superset-ui/legacy-plugin-chart-sankey-loop": "^0.14.1",
"@superset-ui/legacy-plugin-chart-sunburst": "^0.14.1",
"@superset-ui/plugin-chart-table": "^0.14.2",
"@superset-ui/plugin-chart-table": "^0.14.5",
"@superset-ui/legacy-plugin-chart-treemap": "^0.14.1",
"@superset-ui/legacy-plugin-chart-world-map": "^0.14.1",
"@superset-ui/legacy-preset-chart-big-number": "^0.14.1",
Expand Down