fix: dashboard endpoint sig changed #10220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
approved these changes
Jul 1, 2020
|
Can we add a unit test to avoid future regressions? |
bkyryliuk
approved these changes
Jul 1, 2020
# Conflicts: # superset/utils/screenshots.py
dpgaspar
changed the title
villebro
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Thanks for the fix! It seems slightly brittle to accept any kwarg, as linters aren't able to pick up on which are valid and which aren't. Perhaps out of scope for this PR, but to avoid future regressions, perhaps we should have named arguments for the valid ones, and those then get pushed into a dict that is fed to url_for(**kwargs) in get_url_for_path.
|
Good point, I'll merge this and make a subsequent PR |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix(thumbnails): dashboard endpoint sig changed * fix, flask get url for Superset.dashboard * add simple test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
/superset/dashboard/<id>Flask endpoint signature changed on #9939.ADDITIONAL INFORMATION