fix: dashboard endpoint sig changed (#10220)

* fix(thumbnails): dashboard endpoint sig changed

* fix, flask get url for Superset.dashboard

* add simple test

superset/cli.py

@@ -530,7 +530,7 @@ def compute_generic_thumbnail(
                     "Superset.slice", slice_id=model.id, standalone="true"
                 )
             else:
-                url = get_url_path("Superset.dashboard", dashboard_id=model.id)
+                url = get_url_path("Superset.dashboard", dashboard_id_or_slug=model.id)
             func(url, model.digest, force=force)
 
     if not charts_only:

superset/dashboards/api.py

@@ -510,7 +510,9 @@ def thumbnail(
         if not dashboard:
             return self.response_404()
 
-        dashboard_url = get_url_path("Superset.dashboard", dashboard_id=dashboard.id)
+        dashboard_url = get_url_path(
+            "Superset.dashboard", dashboard_id_or_slug=dashboard.id
+        )
         # If force, request a screenshot from the workers
         if kwargs["rison"].get("force", False):
             cache_dashboard_thumbnail.delay(dashboard_url, dashboard.digest, force=True)

superset/models/dashboard.py

@@ -481,7 +481,7 @@ def export_dashboards(  # pylint: disable=too-many-locals
 def event_after_dashboard_changed(  # pylint: disable=unused-argument
     mapper: Mapper, connection: Connection, target: Dashboard
 ) -> None:
-    url = get_url_path("Superset.dashboard", dashboard_id=target.id)
+    url = get_url_path("Superset.dashboard", dashboard_id_or_slug=target.id)
     cache_dashboard_thumbnail.delay(url, target.digest, force=True)
 
 

tests/dashboard_tests.py

@@ -20,17 +20,15 @@
 import unittest
 from random import random
 
-from flask import escape
+from flask import escape, url_for
 from sqlalchemy import func
-from typing import Dict
 
 import tests.test_app
 from superset import db, security_manager
 from superset.connectors.sqla.models import SqlaTable
 from superset.models import core as models
 from superset.models.dashboard import Dashboard
 from superset.models.slice import Slice
-from superset.views import core as views
 
 from .base_tests import SupersetTestCase
 
@@ -57,6 +55,9 @@ def test_dashboard(self):
         for title, url in urls.items():
             assert escape(title) in self.client.get(url).data.decode("utf-8")
 
+    def test_superset_dashboard_url(self):
+        url_for("Superset.dashboard", dashboard_id_or_slug=1)
+
     def test_new_dashboard(self):
         self.login(username="admin")
         dash_count_before = db.session.query(func.count(Dashboard.id)).first()[0]