fix(csv upload): hive params typo #10273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
approved these changes
Jul 9, 2020
|
@serenajiang I'm just about to cut |
serenajiang
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 9, 2020
* fix(csv upload): fix :params typo * fix tests
|
thanks for the fix! |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix(csv upload): fix :params typo * fix tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Missed this bug in #10208 😬 . This was causing hive csv upload to fail because of syntax errors.
:paramwill handle quotes where necessary - we don't need quotes around them.TEST PLAN
Tested in dev env.
ADDITIONAL INFORMATION
@bkyryliuk @etr2460