fix(csv upload): hive params typo (apache#10273)

* fix(csv upload): fix :params typo * fix tests
auxten · Nov 20, 2020 · df3c30e · df3c30e
1 parent 6d43991
commit df3c30e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/superset/db_engine_specs/hive.py b/superset/db_engine_specs/hive.py
@@ -140,11 +140,11 @@ def get_create_table_stmt(  # pylint: disable=too-many-arguments
         }
         if header_line_count is not None and header_line_count >= 0:
             header_line_count += 1
-            tblproperties.append("'skip.header.line.count'=':header_line_count'")
+            tblproperties.append("'skip.header.line.count'=:header_line_count")
             params["header_line_count"] = str(header_line_count)
         if null_values:
             # hive only supports 1 value for the null format
-            tblproperties.append("'serialization.null.format'=':null_value'")
+            tblproperties.append("'serialization.null.format'=:null_value")
             params["null_value"] = null_values[0]
 
         if tblproperties:

diff --git a/tests/db_engine_specs/hive_tests.py b/tests/db_engine_specs/hive_tests.py
@@ -181,7 +181,7 @@ def test_get_create_table_stmt() -> None:
         """CREATE TABLE employee ( eid int, name String, salary String, destination String )
                 ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim
                 STORED AS TEXTFILE LOCATION :location
-                tblproperties ('skip.header.line.count'=':header_line_count', 'serialization.null.format'=':null_value')""",
+                tblproperties ('skip.header.line.count'=:header_line_count, 'serialization.null.format'=:null_value)""",
         {
             "delim": ",",
             "location": "s3a://directory/table",
@@ -195,7 +195,7 @@ def test_get_create_table_stmt() -> None:
         """CREATE TABLE employee ( eid int, name String, salary String, destination String )
                 ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim
                 STORED AS TEXTFILE LOCATION :location
-                tblproperties ('skip.header.line.count'=':header_line_count', 'serialization.null.format'=':null_value')""",
+                tblproperties ('skip.header.line.count'=:header_line_count, 'serialization.null.format'=:null_value)""",
         {
             "delim": ",",
             "location": "s3a://directory/table",
@@ -209,7 +209,7 @@ def test_get_create_table_stmt() -> None:
         """CREATE TABLE employee ( eid int, name String, salary String, destination String )
                 ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim
                 STORED AS TEXTFILE LOCATION :location
-                tblproperties ('skip.header.line.count'=':header_line_count', 'serialization.null.format'=':null_value')""",
+                tblproperties ('skip.header.line.count'=:header_line_count, 'serialization.null.format'=:null_value)""",
         {
             "delim": ",",
             "location": "s3a://directory/table",
@@ -231,6 +231,6 @@ def test_get_create_table_stmt() -> None:
         """CREATE TABLE employee ( eid int, name String, salary String, destination String )
                 ROW FORMAT DELIMITED FIELDS TERMINATED BY :delim
                 STORED AS TEXTFILE LOCATION :location
-                tblproperties ('skip.header.line.count'=':header_line_count')""",
+                tblproperties ('skip.header.line.count'=:header_line_count)""",
         {"delim": ",", "location": "s3a://directory/table", "header_line_count": "101"},
     )