fix: address all disabled pylint checks in charts/api.py #10932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d pylint rule too-many-return-statements
…oved pylint rule too-many-return-statements
…lk_delete method. Applied black
|
Thank you @dpgaspar for the review and merge :) |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Refactored put in charts/api.py to have less return statement. Removed pylint rule too-many-return-statements * Refactored data() in charts/api.py to have less return statement. Removed pylint rule too-many-return-statements * Pylint disabled arguments-differ check is not necessary anymore in put method * Pylint disabled arguments-differ check is not necessary anymore in delete method * Pylint disabled arguments-differ check is not necessary anymore in bulk_delete method. Applied black
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removed disabled pylint checks in
charts/api.py:arguments-differinput(),delete()andbulk_delete()methods isn't an issue anymore,put()anddata()refactored to remove disabled checktoo-many-return-statements.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION