Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra flash import #11121

Merged

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Sep 30, 2020

SUMMARY

@mistercrunch found this bug:
image

This removes the extra error message, and also adds an accept on the file input to only allow the user to select the formats that are valid.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

no visual tests available, but all other regression tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho changed the title remove extra flash import fix: remove extra flash import Sep 30, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #11121 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11121      +/-   ##
==========================================
- Coverage   61.70%   61.64%   -0.07%     
==========================================
  Files         816      826      +10     
  Lines       38586    38973     +387     
  Branches     3650     3669      +19     
==========================================
+ Hits        23808    24023     +215     
- Misses      14598    14769     +171     
- Partials      180      181       +1     
Flag Coverage Δ
#javascript 62.20% <ø> (+0.02%) ⬆️
#python 61.30% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 64.10% <0.00%> (-35.90%) ⬇️
superset/utils/decorators.py 50.76% <0.00%> (-4.24%) ⬇️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx 72.72% <0.00%> (-0.96%) ⬇️
...erset-frontend/src/datasource/DatasourceEditor.jsx 63.63% <0.00%> (-0.59%) ⬇️
superset/db_engine_specs/presto.py 81.42% <0.00%> (-0.54%) ⬇️
superset/utils/pandas_postprocessing.py 76.47% <0.00%> (-0.50%) ⬇️
superset/views/utils.py 84.21% <0.00%> (-0.10%) ⬇️
superset/config.py 90.07% <0.00%> (-0.04%) ⬇️
superset/errors.py 100.00% <0.00%> (ø)
superset/charts/api.py 74.56% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a08fd0...9cefffd. Read the comment docs.

@betodealmeida betodealmeida merged commit 33906c6 into apache:master Oct 1, 2020
@eschutho eschutho deleted the elizabeth/double-error-import branch October 1, 2020 21:31
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* remove extra flash import

* remove yml from accepted file types
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants